Fix binary search to return first occurrence for duplicates#14451
Closed
Pranavwagh1 wants to merge 2 commits intoTheAlgorithms:masterfrom
Closed
Fix binary search to return first occurrence for duplicates#14451Pranavwagh1 wants to merge 2 commits intoTheAlgorithms:masterfrom
Pranavwagh1 wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
### Fix: Binary Search Incorrect Output for Duplicates Previously, the binary_search function returned any matching index when duplicates were present. This change modifies the implementation to return the **first occurrence** of the target element. ### Changes made: - Introduced a `result` variable to track the first occurrence - Continued searching in the left half after finding a match - Updated final return to return `result` instead of immediate index ### Example: Input: [1, 2, 2, 2, 3], target = 2 Output (before): could be 1, 2, or 3 Output (after): 1 (first occurrence) This resolves issue: TheAlgorithms#13840
Closing this pull request as invalid@Pranavwagh1, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Binary Search Incorrect Output for Duplicates
Previously, the binary_search function returned any matching index when duplicates were present.
This change modifies the implementation to return the first occurrence of the target element.
Changes made:
resultvariable to track the first occurrenceresultinstead of immediate indexExample:
Input: [1, 2, 2, 2, 3], target = 2
Output (before): could be 1, 2, or 3
Output (after): 1 (first occurrence)
This resolves issue: #13840
Describe your change:
Checklist: